Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#1547 Fix bazel dependency handling #2361

Merged
merged 3 commits into from
Oct 15, 2024
Merged

iox-#1547 Fix bazel dependency handling #2361

merged 3 commits into from
Oct 15, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 15, 2024 •
edited
Loading

Notes for Reviewer

I did a mistake with my last PR and didn't notice because bzlmod was used. This PR fixes that mistake and deactivates bzlmod for now.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Oct 15, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (5fd7661) to head (ba5e427).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2361   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         440      440           
  Lines       16186    16186           
  Branches     2314     2314           
=======================================
+ Hits        12677    12678    +1     
  Misses       2658     2658           
+ Partials      851      850    -1
Flag Coverage Δ
unittests 78.15% <ø> (+<0.01%) ⬆️
unittests_timing 15.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elBoberido elBoberido merged commit 361030e into eclipse-iceoryx:main Oct 15, 2024
27 checks passed
@elBoberido elBoberido deleted the iox-1547-fix-bazel-dependency-handling branch October 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfenpiff elfenpiff elfenpiff approved these changes

@orecham orecham Awaiting requested review from orecham

Assignees

@elBoberido elBoberido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elBoberido @elfenpiff